| Summary: | Add kdebug_trace signposts for a few WebCore operations | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, esprehn+autocc, kangil.han, rniwa, sabouhallawa, simon.fraser, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 153351 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Simon Fraser (smfr)
2016-01-15 10:41:15 PST
Created attachment 269066 [details]
Patch
Created attachment 269067 [details]
Patch
Comment on attachment 269067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269067&action=review > Source/WTF/wtf/KDebugTracing.h:64 > + : m_exitCode(exitCode) This won't build on non-DARWIN. Created attachment 269070 [details]
Patch
Comment on attachment 269070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269070&action=review > Source/WTF/wtf/KDebugTracing.h:68 > +#if defined(HAVE_KDEBUG_H) Don't we usually use HAVE() macro for these? e.g. #if HAVE(KDEBUG_H) Created attachment 269071 [details]
Patch
Comment on attachment 269071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269071&action=review > Source/WTF/wtf/KDebugTracing.h:27 > +#define KDebugTracing_h Since this is defining generic tracing utilities, perhaps this file should be called something else. Maybe just Tracing.h? > Source/WTF/wtf/KDebugTracing.h:64 > +class TraceEntryExit { Maybe TraceScope? Created attachment 269076 [details]
Patch
|