Bug 153131

Summary:

[mips] Fix regT2 and regT3 trampling in MacroAssembler

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, commit-queue, guijemont, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix general register assignment for mips	none
Fix general register assignment for mips	msaboff: review-
Fix general register assignment for mips	msaboff: review+

Description Julien Brianceau 2016-01-15 08:32:53 PST

Current mips MacroAssembler implementation clobbers regT2 and regT3 because of its addrTempRegister and cmpTempRegister.

Comment 1 Julien Brianceau 2016-01-15 08:38:01 PST

Created attachment 269056 [details]
Fix general register assignment for mips

Comment 2 Julien Brianceau 2016-01-15 08:40:30 PST

Created attachment 269057 [details]
Fix general register assignment for mips

Comment 3 Michael Saboff 2016-01-15 10:11:18 PST

Comment on attachment 269057 [details]
Fix general register assignment for mips

View in context: https://bugs.webkit.org/attachment.cgi?id=269057&action=review

> Source/JavaScriptCore/ChangeLog:7
> +

Please add a description of the change.

Comment 4 Julien Brianceau 2016-01-16 00:55:08 PST

Created attachment 269162 [details]
Fix general register assignment for mips

Comment 5 Michael Saboff 2016-01-16 17:19:44 PST

Comment on attachment 269162 [details]
Fix general register assignment for mips

r=me

Comment 6 Julien Brianceau 2016-01-17 01:17:44 PST

Manually committed r195182: http://trac.webkit.org/changeset/195182