Bug 153072

Summary: Web Inspector: Inspector should use the last sourceURL / sourceMappingURL directive
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[PATCH] For Landing (If Bots Look Good) none

Joseph Pecoraro
Reported 2016-01-13 11:50:22 PST
* SUMMARY Inspector should use the last sourceURL / sourceMappingURL directive, not the first. In some cases, a script may have multiple sourceMappingURL directives, we should use the last. * NOTES - This seems to be what other browsers do (I tested Chrome and Firefox). - I don't see this specced anywhere.
Attachments
[PATCH] Proposed Fix (18.37 KB, patch)
2016-01-13 11:55 PST, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (If Bots Look Good) (18.38 KB, patch)
2016-01-13 12:29 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-01-13 11:50:49 PST
<rdar://problem/24168312>
Joseph Pecoraro
Comment 2 2016-01-13 11:55:20 PST
Created attachment 268886 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2016-01-13 12:12:36 PST
Comment on attachment 268886 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review > LayoutTests/ChangeLog:12 > + Updated line nubmer in output now that code evaluated through the frontend Typo: number
Joseph Pecoraro
Comment 4 2016-01-13 12:29:03 PST
Created attachment 268890 [details] [PATCH] For Landing (If Bots Look Good)
Blaze Burg
Comment 5 2016-01-13 12:33:40 PST
Comment on attachment 268886 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review > LayoutTests/inspector/debugger/sourceURLs.html:194 > + description: "Multiple SourceURLs will return the second.", Test coverage is beautiful. Yay!
Blaze Burg
Comment 6 2016-01-13 12:33:41 PST
Comment on attachment 268886 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review > LayoutTests/inspector/debugger/sourceURLs.html:194 > + description: "Multiple SourceURLs will return the second.", Test coverage is beautiful. Yay!
WebKit Commit Bot
Comment 7 2016-01-13 13:32:58 PST
Comment on attachment 268890 [details] [PATCH] For Landing (If Bots Look Good) Clearing flags on attachment: 268890 Committed r194981: <http://trac.webkit.org/changeset/194981>
Note You need to log in before you can comment on or make changes to this bug.