Bug 153059 – [Streams API] Import tests updated to Jan 13 2016

• Component: New Bugs
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

[Streams API] Import tests updated to Jan 13 2016

[Xabier Rodríguez Calvar]

This comes after comments in bug 152505.

[Xabier Rodríguez Calvar]

Created attachment 268862 [details]
Patch

[youenn fablet]

Comment on attachment 268862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268862&action=review

> LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:45
> +  return promise_rejects(t, controllerError, rs.getReader().closed);

Test below has a message, but not this one.
Might be good to add one message upstream?

[Xabier Rodríguez Calvar]

(In reply to comment #3)
> Comment on attachment 268862 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268862&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:45
> > +  return promise_rejects(t, controllerError, rs.getReader().closed);
> 
> Test below has a message, but not this one.
> Might be good to add one message upstream?

Created the pull request for this at https://github.com/whatwg/streams/pull/422.

As soon as it gets accepted, I'll land it here too.

[Xabier Rodríguez Calvar]

Created attachment 269216 [details]
Patch for landing

[Xabier Rodríguez Calvar]

(In reply to comment #4)
> > Test below has a message, but not this one.
> > Might be good to add one message upstream?
> 
> Created the pull request for this at
> https://github.com/whatwg/streams/pull/422.
> 
> As soon as it gets accepted, I'll land it here too.

The pull request was not accepted, so I am landing this here.

[WebKit Commit Bot]

Comment on attachment 269216 [details]
Patch for landing

Clearing flags on attachment: 269216

Committed r195229: <http://trac.webkit.org/changeset/195229>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.