| Summary: | [Cocoa] Font features are not applied to the system font | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, jonlee, mmaxfield, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2016-01-12 19:32:32 PST
Created attachment 268846 [details]
Patch
Created attachment 268849 [details]
Patch
Comment on attachment 268849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268849&action=review > LayoutTests/fast/text/system-font-features-expected.html:7 > +<div style="font: 50px -apple-system-monospaced-numbers;">0123456789</div> Eventually we're going to want to remove this style. Is there another way we could write this test? Comment on attachment 268849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268849&action=review >> LayoutTests/fast/text/system-font-features-expected.html:7 >> +<div style="font: 50px -apple-system-monospaced-numbers;">0123456789</div> > > Eventually we're going to want to remove this style. Is there another way we could write this test? I tried, but unfortunately it looks like I can't use -mismatch-expected results because of the system font mocking we are doing for testing. :( Comment on attachment 268849 [details] Patch Clearing flags on attachment: 268849 Committed r195150: <http://trac.webkit.org/changeset/195150> All reviewed patches have been landed. Closing bug. |