Bug 153041

Summary:

Ask UI Process before sending redirect requests when downloading

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Alex Christensen 2016-01-12 15:04:53 PST

Ask UI Process before sending redirect requests when downloading

Comment 1 Alex Christensen 2016-01-12 15:05:15 PST

Created attachment 268815 [details]
Patch

Comment 2 Darin Adler 2016-01-19 23:19:25 PST

Comment on attachment 268815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268815&action=review

I’m surprised Anders didn’t review. Looks OK to me.

> Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp:133
> +    RefPtr<DownloadProxy> protect(this);

I suggest the name protectedThis rather than “protect” for a local variable that we are actually using like this.

Comment 3 Alex Christensen 2016-01-20 10:24:19 PST

http://trac.webkit.org/changeset/195357