Bug 153041 - Ask UI Process before sending redirect requests when downloading
Summary: Ask UI Process before sending redirect requests when downloading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-12 15:04 PST by Alex Christensen
Modified: 2016-01-20 10:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.44 KB, patch)
2016-01-12 15:05 PST, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-01-12 15:04:53 PST 
Ask UI Process before sending redirect requests when downloading
Comment 1 Alex Christensen 2016-01-12 15:05:15 PST 
Created attachment 268815 [details]
Patch
Comment 2 Darin Adler 2016-01-19 23:19:25 PST 
Comment on attachment 268815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268815&action=review

I’m surprised Anders didn’t review. Looks OK to me.

> Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp:133
> +    RefPtr<DownloadProxy> protect(this);

I suggest the name protectedThis rather than “protect” for a local variable that we are actually using like this.
Comment 3 Alex Christensen 2016-01-20 10:24:19 PST 
http://trac.webkit.org/changeset/195357