WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153041
Ask UI Process before sending redirect requests when downloading
https://bugs.webkit.org/show_bug.cgi?id=153041
Summary
Ask UI Process before sending redirect requests when downloading
Alex Christensen
Reported
2016-01-12 15:04:53 PST
Ask UI Process before sending redirect requests when downloading
Attachments
Patch
(10.44 KB, patch)
2016-01-12 15:05 PST
,
Alex Christensen
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-01-12 15:05:15 PST
Created
attachment 268815
[details]
Patch
Darin Adler
Comment 2
2016-01-19 23:19:25 PST
Comment on
attachment 268815
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=268815&action=review
I’m surprised Anders didn’t review. Looks OK to me.
> Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp:133 > + RefPtr<DownloadProxy> protect(this);
I suggest the name protectedThis rather than “protect” for a local variable that we are actually using like this.
Alex Christensen
Comment 3
2016-01-20 10:24:19 PST
http://trac.webkit.org/changeset/195357
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug