Bug 15303

Summary:

Remove now-redundant code to restore dialog arguments after clear

Product:

WebKit

Reporter:

mitz

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Remove code to restore dialog arguments	none
Remove code to restore dialog arguments	mjs: review+

mitz

Reported 2007-09-28 03:07:37 PDT

Following <http://trac.webkit.org/projects/webkit/changeset/25783>, window properties, including dialog arguments, are not cleared when a newly created modal dialog loads its document. Therefore the code introduced in <http://trac.webkit.org/projects/webkit/changeset/25576> to protect dialog arguments is redundant. I have a patch that reverts it.

Attachments
Remove code to restore dialog arguments (6.28 KB, patch) 2007-09-28 03:14 PDT, mitz	no flags	Details Formatted Diff Diff
Remove code to restore dialog arguments (5.53 KB, patch) 2007-09-28 03:22 PDT, mitz	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2007-09-28 03:14:23 PDT

Created attachment 16429 [details] Remove code to restore dialog arguments

mitz

Comment 2 2007-09-28 03:22:44 PDT

Created attachment 16430 [details] Remove code to restore dialog arguments ...without re-introducing coding style errors.

Maciej Stachowiak

Comment 3 2007-09-29 19:29:19 PDT

Comment on attachment 16430 [details] Remove code to restore dialog arguments r=me for trunk (since this won't actually change behavior, it's just a cleanup).

Mark Rowe (bdash)

Comment 4 2007-10-14 04:46:01 PDT

Landed in r26584.

Note You need to log in before you can comment on or make changes to this bug.