Bug 15303 - Remove now-redundant code to restore dialog arguments after clear
Summary: Remove now-redundant code to restore dialog arguments after clear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-28 03:07 PDT by mitz
Modified: 2007-10-14 04:46 PDT (History)
0 users

See Also:


Attachments
Remove code to restore dialog arguments (6.28 KB, patch)
2007-09-28 03:14 PDT, mitz
no flags Details | Formatted Diff | Diff
Remove code to restore dialog arguments (5.53 KB, patch)
2007-09-28 03:22 PDT, mitz
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-09-28 03:07:37 PDT
Following <http://trac.webkit.org/projects/webkit/changeset/25783>, window properties, including dialog arguments, are not cleared when a newly created modal dialog loads its document. Therefore the code introduced in <http://trac.webkit.org/projects/webkit/changeset/25576> to protect dialog arguments is redundant. I have a patch that reverts it.
Comment 1 mitz 2007-09-28 03:14:23 PDT
Created attachment 16429 [details]
Remove code to restore dialog arguments
Comment 2 mitz 2007-09-28 03:22:44 PDT
Created attachment 16430 [details]
Remove code to restore dialog arguments

...without re-introducing coding style errors.
Comment 3 Maciej Stachowiak 2007-09-29 19:29:19 PDT
Comment on attachment 16430 [details]
Remove code to restore dialog arguments

r=me for trunk (since this won't actually change behavior, it's just a cleanup).
Comment 4 Mark Rowe (bdash) 2007-10-14 04:46:01 PDT
Landed in r26584.