Bug 153015

Summary: [GTK] Fix return value of some paint methods in RenderThemeGtk
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2016-01-12 08:55:22 PST 
It's a bit confusing, but the bool value returned by paint methods in RenderTheme means whether the appearance is supported or not, so we should return true when not supported (so we didn't paint anything) and false when supported (so we actually painted the theme part).
Comment 1 Carlos Garcia Campos 2016-01-12 08:57:13 PST 
Created attachment 268772 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-12 11:22:50 PST 
Comment on attachment 268772 [details]
Patch

Watch the bots....
Comment 3 Carlos Garcia Campos 2016-01-12 22:47:31 PST 
Committed r194955: <http://trac.webkit.org/changeset/194955>