Bug 153003

Summary: Web Inspector: creating a gradient in the Visual sidebar causes a crash
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2016-01-11 21:25:57 PST
* STEPS TO REPRODUCE 1. Go to <www.apple.com> 2. Inspect the <body> 3. In the Visual sidebar, go to Background > Style 4. Click the + button on the list editor and select "Linear Gradient" in the dropdown next to "Type" 5. Click the swatch element immediately to the right of the "Type" label (the gradient editor should open) 6. Click slightly underneath the gradient preview area to add a color stop * Expected Color stop is added to (previously empty) gradient * Actual Crashes
Attachments
Patch (1.89 KB, patch)
2016-01-11 21:28 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2016-01-11 21:28:40 PST
Created attachment 268744 [details] Patch
Blaze Burg
Comment 2 2016-01-11 22:56:03 PST
By crash, do you mean that WebCore crashed? We should also investigate fixing that, as invalid CSS from the inspector should never cause a segfault.
Blaze Burg
Comment 3 2016-01-11 22:56:50 PST
Comment on attachment 268744 [details] Patch r=me
Devin Rousso
Comment 4 2016-01-12 00:38:14 PST
(In reply to comment #2) > By crash, do you mean that WebCore crashed? We should also investigate > fixing that, as invalid CSS from the inspector should never cause a segfault. Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I figured that that was considered a "crash" for the Web Inspector. Is there a better term for it?
Blaze Burg
Comment 5 2016-01-12 10:12:48 PST
(In reply to comment #4) > (In reply to comment #2) > > By crash, do you mean that WebCore crashed? We should also investigate > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > figured that that was considered a "crash" for the Web Inspector. Is there > a better term for it? That's an uncaught exception, and is less severe. The dialog only appears in engineering builds and can be dismissed. A crash occurs when the Web Inspector or Safari window disappears completely and a crash report is collected. If that happens, you can see the stack trace dumped to stdout or added to the list in Console.app.
Devin Rousso
Comment 6 2016-01-12 10:30:10 PST
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > By crash, do you mean that WebCore crashed? We should also investigate > > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > > figured that that was considered a "crash" for the Web Inspector. Is there > > a better term for it? > > That's an uncaught exception, and is less severe. The dialog only appears in > engineering builds and can be dismissed. > > A crash occurs when the Web Inspector or Safari window disappears completely > and a crash report is collected. If that happens, you can see the stack > trace dumped to stdout or added to the list in Console.app. Ah OK that makes more sense. I'll refer to it as such in the future. Sorry for the confusion!
WebKit Commit Bot
Comment 7 2016-01-12 10:44:37 PST
Comment on attachment 268744 [details] Patch Clearing flags on attachment: 268744 Committed r194901: <http://trac.webkit.org/changeset/194901>
WebKit Commit Bot
Comment 8 2016-01-12 10:44:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2016-01-14 11:31:08 PST
<rdar://problem/24191708>
Note You need to log in before you can comment on or make changes to this bug.