Bug 152996

Summary: Web Inspector: Move helper methods for getting icons/text to TimelineTabContentView
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Matt Baker
Reported 2016-01-11 16:28:49 PST
* SUMMARY Move helper methods for getting icons/text to TimelineTabContentView. Static methods in TimelineSidebarPanel can simply be moved. Code for getting icons and titles for timeline records should be broken out of TimelineRecordTreeElement, and made into helper methods. Refactoring this will simplify removing the Timelines navigation sidebar in the near future.
Attachments
[Patch] Proposed Fix (19.99 KB, patch)
2016-01-11 16:37 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (20.12 KB, patch)
2016-01-12 15:11 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-01-11 16:37:27 PST
Created attachment 268726 [details] [Patch] Proposed Fix
Blaze Burg
Comment 2 2016-01-12 11:03:54 PST
Comment on attachment 268726 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268726&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:35 > + if (includeDetailsInMainTitle && timelineRecord.type === WebInspector.TimelineRecord.Type.Script && timelineRecord.eventType === WebInspector.ScriptTimelineRecord.EventType.TimerInstalled) { This change isn't described in the changelog. It seems to be extracted from... > Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:-100 > - let timeoutString = Number.secondsToString(timelineRecord.details.timeout / 1000); .. here
Matt Baker
Comment 3 2016-01-12 15:11:23 PST
Created attachment 268816 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 4 2016-01-12 16:04:40 PST
Comment on attachment 268816 [details] [Patch] Proposed Fix Clearing flags on attachment: 268816 Committed r194932: <http://trac.webkit.org/changeset/194932>
WebKit Commit Bot
Comment 5 2016-01-12 16:04:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.