Bug 152982

Summary: Standardize the usage of "branch" vs. "branchName".
Product: WebKit Reporter: Jason Marcell <jmarcell>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, ap, dbates, dean_johnson, dino, jmarcell, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch dbates: review+

Jason Marcell
Reported 2016-01-11 12:15:10 PST
Standardize the usage of "branch" vs. "branchName".
Attachments
Patch (8.09 KB, patch)
2016-01-11 12:18 PST, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Patch (138.28 KB, patch)
2016-01-11 14:18 PST, Jason Marcell 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2016-01-11 17:03 PST, Jason Marcell 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jason Marcell
Comment 1 2016-01-11 12:18:59 PST
Created attachment 268702 [details] Patch
Daniel Bates
Comment 2 2016-01-11 13:02:20 PST
Comment on attachment 268702 [details] Patch r=me cq- since this patch depends on the patch for bug #152910 and it has not landed as of the time of writing.
Jason Marcell
Comment 3 2016-01-11 14:18:26 PST
Created attachment 268710 [details] Patch
Jason Marcell
Comment 4 2016-01-11 14:30:43 PST
(In reply to comment #3) > Created attachment 268710 [details] > Patch This patch was not supposed to be uploaded here nor was the original patch supposed to be obsoleted. The webkit-patch command did this erroneously. I've written up a bug to track this erroneous behavior: https://bugs.webkit.org/show_bug.cgi?id=152987
Jason Marcell
Comment 5 2016-01-11 17:03:11 PST
Created attachment 268730 [details] Patch
Jason Marcell
Comment 6 2016-01-11 17:04:15 PST
Comment on attachment 268730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268730&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:69 > + return (!commit.containsBranchLocation || commit.branchName === branchName) && filter(commit); I had accidentally left this change out of the original patch.
Jason Marcell
Comment 7 2016-01-14 14:33:47 PST
Landed: https://trac.webkit.org/changeset/195076
Note You need to log in before you can comment on or make changes to this bug.