Bug 152971

Summary: run-jsc-stress-tests should try to figure out a JSC path
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, ossy, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch ysuzuki: review+

Saam Barati
Reported 2016-01-10 23:52:48 PST
If it does, we can run it just like this: `run-esc-stress-tests <directory/to/some/tests> <path/to/a/yaml>`
Attachments
patch (3.55 KB, patch)
2016-01-11 00:06 PST, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-01-11 00:06:17 PST
Created attachment 268677 [details] patch
Yusuke Suzuki
Comment 2 2016-01-11 00:25:39 PST
Comment on attachment 268677 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=268677&action=review r=me > Tools/Scripts/run-jsc-stress-tests:264 > + jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc") Nits: we can write this as `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`. > Tools/Scripts/run-jsc-stress-tests:265 > + end And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`, we can support EFL / GTK.
Saam Barati
Comment 3 2016-01-11 20:41:10 PST
(In reply to comment #2) > Comment on attachment 268677 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268677&action=review > > r=me > > > Tools/Scripts/run-jsc-stress-tests:264 > > + jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc") > > Nits: we can write this as > `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`. > > > Tools/Scripts/run-jsc-stress-tests:265 > > + end > > And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`, > we can support EFL / GTK. Thanks for the review
Saam Barati
Comment 4 2016-01-11 20:41:36 PST
landed in: http://trac.webkit.org/changeset/194885
Note You need to log in before you can comment on or make changes to this bug.