Bug 152945

Summary:

REGRESSION (r194426): First email field is not autofilled on amazon.com

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

alan

Reported 2016-01-09 09:17:21 PST

1. go to https://www.amazon.com/ap/register?_encoding=UTF8&openid.assoc_handle=usflex&openid.claimed_id=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.identity=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.mode=checkid_setup&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0&openid.ns.pape=http%3A%2F%2Fspecs.openid.net%2Fextensions%2Fpape%2F1.0&openid.pape.max_auth_age=0&openid.return_to=https%3A%2F%2Fwww.amazon.com%2Fgp%2Fyourstore%2Fhome%3Fie%3DUTF8%26ref_%3Dnav_newcust 2. cmd-shift-A or click and arrow down to select autofill options. * RESULTS First email field is not filled, second email is filled.

Attachments
Patch (2.12 KB, patch) 2016-01-09 09:41 PST, alan	no flags	Details Formatted Diff Diff
Patch (4.45 KB, patch) 2016-01-09 15:05 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2016-01-09 09:18:05 PST

rdar://problem/24082914

alan

Comment 2 2016-01-09 09:41:54 PST

Created attachment 268622 [details] Patch

Simon Fraser (smfr)

Comment 3 2016-01-09 10:38:55 PST

Comment on attachment 268622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268622&action=review > Source/WebCore/ChangeLog:11 > + Unable to test. Needs Safari autofill interaction. This is a shame. Can't you simulate it with two text fields? > Source/WebCore/page/FrameView.cpp:2651 > + // We already have a pending (full) layout. Just mark the subtree for layout. I can't see how you know you have a pending layout here.

alan

Comment 4 2016-01-09 14:05:35 PST

(In reply to comment #3) > Comment on attachment 268622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268622&action=review > > > Source/WebCore/ChangeLog:11 > > + Unable to test. Needs Safari autofill interaction. > > This is a shame. Can't you simulate it with two text fields? I might. > > > Source/WebCore/page/FrameView.cpp:2651 > > + // We already have a pending (full) layout. Just mark the subtree for layout. > > I can't see how you know you have a pending layout here. We early return from this function when layout is pending.

alan

Comment 5 2016-01-09 15:05:54 PST

Created attachment 268629 [details] Patch

WebKit Commit Bot

Comment 6 2016-01-09 16:39:12 PST

Comment on attachment 268629 [details] Patch Clearing flags on attachment: 268629 Committed r194823: <http://trac.webkit.org/changeset/194823>

WebKit Commit Bot

Comment 7 2016-01-09 16:39:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.