Bug 152942

Summary: Use a profile to store allocation structures for subclasses of InternalFunctions
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142591, 152949    
Attachments:
Description Flags
Patch
msaboff: review+
Benchmark results none

Keith Miller
Reported 2016-01-08 22:04:58 PST
Use a profile to store allocation structures for subclasses of InternalFunctions
Attachments
Patch (73.02 KB, patch)
2016-01-08 22:21 PST, Keith Miller 		msaboff: review+
DetailsFormatted DiffDiff
Benchmark results (64.80 KB, text/plain)
2016-01-09 16:26 PST, Keith Miller 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-01-08 22:21:01 PST
Created attachment 268614 [details] Patch
Keith Miller
Comment 2 2016-01-09 16:26:45 PST
Created attachment 268630 [details] Benchmark results
Michael Saboff
Comment 3 2016-01-11 13:14:03 PST
Comment on attachment 268614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds Spelling *InternalFunctionAllocationProfile* > Source/JavaScriptCore/ChangeLog:10 > + InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to ditto spelling.
Keith Miller
Comment 4 2016-01-11 13:25:31 PST
Comment on attachment 268614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds > > Spelling *InternalFunctionAllocationProfile* Fixed. >> Source/JavaScriptCore/ChangeLog:10 >> + InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to > > ditto spelling. Fixed both Alloctations.
Keith Miller
Comment 5 2016-01-11 13:31:19 PST
Committed r194863: <http://trac.webkit.org/changeset/194863>
Csaba Osztrogonác
Comment 6 2016-01-12 03:22:59 PST
(In reply to comment #5) > Committed r194863: <http://trac.webkit.org/changeset/194863> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1536 /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/JavaScriptCore/runtime/FunctionRareData.h:29:10: fatal error: 'InternalFunctionAllocationProfile.h' file not found #include "InternalFunctionAllocationProfile.h" ^
Csaba Osztrogonác
Comment 7 2016-01-12 03:23:45 PST
Let's see if a clean build helps or not: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1559
Keith Miller
Comment 8 2016-01-27 14:37:13 PST
*** Bug 152710 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.