| Summary: | Use a profile to store allocation structures for subclasses of InternalFunctions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, mark.lam, msaboff, ossy, saam | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 142591, 152949 | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2016-01-08 22:04:58 PST
Created attachment 268614 [details]
Patch
Created attachment 268630 [details]
Benchmark results
Comment on attachment 268614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds Spelling *InternalFunctionAllocationProfile* > Source/JavaScriptCore/ChangeLog:10 > + InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to ditto spelling. Comment on attachment 268614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds > > Spelling *InternalFunctionAllocationProfile* Fixed. >> Source/JavaScriptCore/ChangeLog:10 >> + InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to > > ditto spelling. Fixed both Alloctations. Committed r194863: <http://trac.webkit.org/changeset/194863> (In reply to comment #5) > Committed r194863: <http://trac.webkit.org/changeset/194863> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1536 /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/JavaScriptCore/runtime/FunctionRareData.h:29:10: fatal error: 'InternalFunctionAllocationProfile.h' file not found #include "InternalFunctionAllocationProfile.h" ^ Let's see if a clean build helps or not: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1559 *** Bug 152710 has been marked as a duplicate of this bug. *** |