Bug 152934

Summary: FTL B3 should do varargs tail calls and stack overflows
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch saam: review+

Description Filip Pizlo 2016-01-08 16:16:09 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-08 16:18:42 PST 
Created attachment 268597 [details]
the patch
Comment 2 WebKit Commit Bot 2016-01-08 16:20:59 PST 
Attachment 268597 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:344:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:352:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-01-08 16:21:44 PST 
Comment on attachment 268597 [details]
the patch

Hold on, this isn't working right.
Comment 4 Filip Pizlo 2016-01-08 16:24:01 PST 
Comment on attachment 268597 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268597&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:345
> +                jit.copyCalleeSavesToVMCalleeSavesBuffer();

I have to add AllowMacroScratchRegisterUsage above here.
Comment 5 Saam Barati 2016-01-08 16:33:21 PST 
Comment on attachment 268597 [details]
the patch

r=me
Comment 6 Filip Pizlo 2016-01-08 16:38:39 PST 
Landed in http://trac.webkit.org/changeset/194805