Bug 152894

Summary:

run-webkit-tests mis-counts totals when there are other crashes

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, glenn, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Aakash Jain

Reported 2016-01-08 09:07:43 PST

see <rdar://problem/24098697> When there are "other" crashes, the "didn't run" in run-webkit-tests output are wrong. e.g.: 8 tests ran as expected, 2 didn't (-2 didn't run): And: 15:34:07.115 52921 10 slowest tests that are not marked as SLOW and did not timeout/crash: 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html took 2.7 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html took 0.5 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html took 0.3 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html took 0.3 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html took 0.3 seconds 15:34:07.115 52921 suggestd-53291 took 0.0 seconds 15:34:07.115 52921 suggestd-53097 took 0.0 seconds 15:34:07.115 52921 15:34:07.115 52921 Tests marked as SLOW: 15:34:07.115 52921 15:34:07.115 52921 Tests that timed out or crashed: 15:34:07.115 52921 15:34:07.115 52921 Time to process slowest subdirectories: 15:34:07.115 52921 took 0.0 seconds to run 2 tests. 15:34:07.115 52921 all_tests took 5.9 seconds to run 8 tests. 15:34:07.115 52921 15:34:07.115 52921 15:34:07.115 52921 15:34:07.115 52921 8 tests ran as expected, 2 didn't (-2 didn't run)

Attachments
Proposed patch (1.45 KB, patch) 2016-01-08 09:21 PST, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2016-01-08 09:21:04 PST

Created attachment 268547 [details] Proposed patch

Alexey Proskuryakov

Comment 2 2016-01-08 09:31:08 PST

It would be good to add a regression test for this.

Aakash Jain

Comment 3 2016-01-08 09:34:23 PST

ok, will add.

WebKit Commit Bot

Comment 4 2016-01-08 10:20:44 PST

Comment on attachment 268547 [details] Proposed patch Clearing flags on attachment: 268547 Committed r194768: <http://trac.webkit.org/changeset/194768>

WebKit Commit Bot

Comment 5 2016-01-08 10:20:47 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.