Bug 152870

Summary: Cleanup: XSS Auditor should avoid re-evaluating the parsed script tag
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim
Priority: P2 Keywords: BlinkMergeCandidate, XSSAuditor
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2016-01-07 16:57:40 PST
Currently the XSS Auditor caches the decoded start tag of a script as an optimization to avoid decoding it again when filtering the character data of the script. We can do reduce memory usage by caching a boolean as to whether HTTP response contains the decoded string instead of caching the decoded string. Blink Issue: <https://chromiumcodereview.appspot.com/19446002>
Attachments
Patch (3.59 KB, patch)
2016-01-07 16:58 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-01-07 16:58:36 PST
Created attachment 268508 [details] Patch
Brent Fulgham
Comment 2 2016-01-13 12:48:50 PST
Comment on attachment 268508 [details] Patch r=me.
WebKit Commit Bot
Comment 3 2016-01-13 13:45:21 PST
Comment on attachment 268508 [details] Patch Clearing flags on attachment: 268508 Committed r194982: <http://trac.webkit.org/changeset/194982>
WebKit Commit Bot
Comment 4 2016-01-13 13:45:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.