| Summary: | FTL B3 should do BitAnd binary snippets | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 152668 | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2016-01-04 13:36:36 PST
Created attachment 268230 [details]
the patch
Attachment 268230 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7485: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7497: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 268230 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268230&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > + template<typename BinaryArithOpGenerator> Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match the function name? (In reply to comment #3) > Comment on attachment 268230 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268230&action=review > > r=me > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > > + template<typename BinaryArithOpGenerator> > > Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match > the function name? Good idea, will do. Landed in http://trac.webkit.org/changeset/194556 |