RESOLVED FIXED Bug 152713
FTL B3 should do BitAnd binary snippets 
https://bugs.webkit.org/show_bug.cgi?id=152713
Summary FTL B3 should do BitAnd binary snippets
Filip Pizlo
Reported 2016-01-04 13:36:36 PST
Patch forthcoming.
Attachments
the patch (5.95 KB, patch)
2016-01-04 13:51 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-04 13:51:07 PST
Created attachment 268230 [details] the patch
WebKit Commit Bot
Comment 2 2016-01-04 13:54:01 PST
Attachment 268230 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7485: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7497: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2016-01-04 13:58:18 PST
Comment on attachment 268230 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268230&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > + template<typename BinaryArithOpGenerator> Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match the function name?
Filip Pizlo
Comment 4 2016-01-04 13:58:40 PST
(In reply to comment #3) > Comment on attachment 268230 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268230&action=review > > r=me > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > > + template<typename BinaryArithOpGenerator> > > Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match > the function name? Good idea, will do.
Filip Pizlo
Comment 5 2016-01-04 15:01:09 PST
Landed in http://trac.webkit.org/changeset/194556
Note You need to log in before you can comment on or make changes to this bug.