Bug 152712

Summary: Hardware keyboard key-commands stop responding when viewing PDFs
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, enrica, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Tim Horton 2016-01-04 13:26:46 PST
Hardware keyboard key-commands stop responding when viewing PDFs
Comment 1 Tim Horton 2016-01-04 13:27:00 PST
Created attachment 268229 [details]
Patch
Comment 2 mitz 2016-01-04 13:30:39 PST
Comment on attachment 268229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268229&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:793
> +    return [[self _currentContentView] becomeFirstResponder] || [super becomeFirstResponder];

Can’t use a dot here?
Comment 3 Tim Horton 2016-01-04 14:42:51 PST
http://trac.webkit.org/changeset/194557