Bug 152692

Summary: Web Inspector: Add basic Animation section to Visual Sidebar
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 172579    
Attachments:
Description Flags
Patch
timothy: review+
Patch none

Devin Rousso
Reported 2016-01-04 09:49:48 PST
We currently do not have the capability in Web Inspector to autocomplete the list of keyframes on the page, but the rest of the animation properties are all keyword based, so they can be added.
Attachments
Patch (12.20 KB, patch)
2016-01-04 10:48 PST, Devin Rousso 		timothy: review+
DetailsFormatted DiffDiff
Patch (12.64 KB, patch)
2016-01-06 14:46 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-04 09:49:58 PST
<rdar://problem/24042244>
Devin Rousso
Comment 2 2016-01-04 10:48:40 PST
Created attachment 268205 [details] Patch
Joseph Pecoraro
Comment 3 2016-01-04 20:55:28 PST
Comment on attachment 268205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review > Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3 > +<!-- Copyright © 2016 Apple Inc. All rights reserved. --> > +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. --> Both of these needed? Or just yours?
Devin Rousso
Comment 4 2016-01-04 21:08:06 PST
Comment on attachment 268205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review >> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3 >> +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. --> > > Both of these needed? Or just yours? I put both because this icon was almost a direct copy of UserInterface/Images/Pause.svg
Timothy Hatcher
Comment 5 2016-01-06 10:22:01 PST
Comment on attachment 268205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review > Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:2 > +<!-- Copyright © 2016 Apple Inc. All rights reserved. --> This would be 2015 still. >>> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3 >>> +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. --> >> >> Both of these needed? Or just yours? > > I put both because this icon was almost a direct copy of UserInterface/Images/Pause.svg You should add your copyright line to the license header in copy-user-interface-resources.pl.
Devin Rousso
Comment 6 2016-01-06 14:46:24 PST
Created attachment 268415 [details] Patch
WebKit Commit Bot
Comment 7 2016-01-06 15:46:39 PST
Comment on attachment 268415 [details] Patch Clearing flags on attachment: 268415 Committed r194673: <http://trac.webkit.org/changeset/194673>
WebKit Commit Bot
Comment 8 2016-01-06 15:46:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.