Bug 152671

Summary: Web Inspector: add a DebugUI context menu item for saving inspector protocol traffic to file
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216380
Bug Depends on:    
Bug Blocks: 147066    
Attachments:
Description Flags
Proposed Fix timothy: review+

Description BJ Burg 2016-01-03 15:23:28 PST 
Yay.
Comment 1 Radar WebKit Bug Importer 2016-01-03 15:23:41 PST 
<rdar://problem/24034007>
Comment 2 BJ Burg 2016-01-03 16:09:27 PST 
Created attachment 268153 [details]
Proposed Fix
Comment 3 Timothy Hatcher 2016-01-04 10:58:23 PST 
Comment on attachment 268153 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268153&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:1390
> +        }, /* checked */ isCapturingTraffic);

Comment here isn't that useful.

> Source/WebInspectorUI/UserInterface/Base/Main.js:1394
> +        protocolSubMenu.appendItem(WebInspector.unlocalizedString("Export Trace..."), () => {

Proper ellipsis.

> Source/WebInspectorUI/UserInterface/Base/Main.js:1397
> +        }, /* disabled */ !isCapturingTraffic);

Ditto.
Comment 4 BJ Burg 2016-01-04 12:37:29 PST 
Committed r194546: <http://trac.webkit.org/changeset/194546>
Comment 5 Joseph Pecoraro 2016-01-04 19:01:30 PST 
Comment on attachment 268153 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268153&action=review

> Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:37
> +    addEntry(entry) {

Style: Braces

> Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:41
> +    get saveData() {

Style: Braces