Bug 152671

Summary: Web Inspector: add a DebugUI context menu item for saving inspector protocol traffic to file
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216380
Bug Depends on:    
Bug Blocks: 147066    
Attachments:
Description Flags
Proposed Fix timothy: review+

Blaze Burg
Reported 2016-01-03 15:23:28 PST
Yay.
Attachments
Proposed Fix (27.53 KB, patch)
2016-01-03 16:09 PST, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-03 15:23:41 PST
<rdar://problem/24034007>
Blaze Burg
Comment 2 2016-01-03 16:09:27 PST
Created attachment 268153 [details] Proposed Fix
Timothy Hatcher
Comment 3 2016-01-04 10:58:23 PST
Comment on attachment 268153 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268153&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1390 > + }, /* checked */ isCapturingTraffic); Comment here isn't that useful. > Source/WebInspectorUI/UserInterface/Base/Main.js:1394 > + protocolSubMenu.appendItem(WebInspector.unlocalizedString("Export Trace..."), () => { Proper ellipsis. > Source/WebInspectorUI/UserInterface/Base/Main.js:1397 > + }, /* disabled */ !isCapturingTraffic); Ditto.
Blaze Burg
Comment 4 2016-01-04 12:37:29 PST
Committed r194546: <http://trac.webkit.org/changeset/194546>
Joseph Pecoraro
Comment 5 2016-01-04 19:01:30 PST
Comment on attachment 268153 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268153&action=review > Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:37 > + addEntry(entry) { Style: Braces > Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:41 > + get saveData() { Style: Braces
Note You need to log in before you can comment on or make changes to this bug.