| Summary: | Web Inspector: Visual sidebar selector section displays inherited section for non-editable rules | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 268127 [details]
Patch
Comment on attachment 268127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268127&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + Only add a new inherited section header once the first inherited rule is added. Please edit this comment to say "if it will contain at least one inherited rule". The separator is added before the inherited rule, not after it. Created attachment 268163 [details]
Patch
Good call on the comment @Brian.
Comment on attachment 268163 [details] Patch Clearing flags on attachment: 268163 Committed r194524: <http://trac.webkit.org/changeset/194524> All reviewed patches have been landed. Closing bug. |
Created attachment 268126 [details] Screenshot of Bug See attached screenshot (look at the two sections that are back to back called "Inherited from center" and "Inherited from body#gsr.hp.vasq")