Bug 152654 – Build fails for aarch64/linux on when building with clang

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Khem Raj]

On OpenEmbedded when building webkitgtk using clang for aarch64/linux target build fails with

Source/JavaScriptCore/assembler/ARM64Assembler.h:2857:33: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'void *'
        __builtin___clear_cache(reinterpret_cast<void*>(begin), reinterpret_cast<void*>(end));
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[Khem Raj]

Created attachment 268114 [details]
Fix aarch64/linux build with clang

[Michael Saboff]

Comment on attachment 268114 [details]
Fix aarch64/linux build with clang

r=me

[WebKit Commit Bot]

Comment on attachment 268114 [details]
Fix aarch64/linux build with clang

Clearing flags on attachment: 268114

Committed r194505: <http://trac.webkit.org/changeset/194505>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

(In reply to comment #3)
> Comment on attachment 268114 [details]
> Fix aarch64/linux build with clang
> 
> Clearing flags on attachment: 268114
> 
> Committed r194505: <http://trac.webkit.org/changeset/194505>

The ChangeLog entry for this change neither lists the name of the reviewer (Michael Saboff) nor conforms to format of a ChangeLog entry described in <https://webkit.org/contributing-code/#changelog-files>.

Even though this a build fix (which could be landed by a committer/reviewer "Unreviewed") it was formally reviewed and landed. Therefore its ChangeLog should reflect the reviewer.

[Khem Raj]

Created attachment 268142 [details]
patch to fix clang/aarch64/Linux

Addressed review comments.

[Filip Pizlo]

Fixed the ChangeLog in http://trac.webkit.org/changeset/194517

[Filip Pizlo]

Comment on attachment 268142 [details]
patch to fix clang/aarch64/Linux

Obsolete patch.