Summary: | Build fails for aarch64/linux on when building with clang | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Khem Raj <raj.khem> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dbates, fpizlo, keith_miller, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Khem Raj
2016-01-02 14:58:35 PST
Created attachment 268114 [details]
Fix aarch64/linux build with clang
Comment on attachment 268114 [details]
Fix aarch64/linux build with clang
r=me
Comment on attachment 268114 [details] Fix aarch64/linux build with clang Clearing flags on attachment: 268114 Committed r194505: <http://trac.webkit.org/changeset/194505> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Comment on attachment 268114 [details] > Fix aarch64/linux build with clang > > Clearing flags on attachment: 268114 > > Committed r194505: <http://trac.webkit.org/changeset/194505> The ChangeLog entry for this change neither lists the name of the reviewer (Michael Saboff) nor conforms to format of a ChangeLog entry described in <https://webkit.org/contributing-code/#changelog-files>. Even though this a build fix (which could be landed by a committer/reviewer "Unreviewed") it was formally reviewed and landed. Therefore its ChangeLog should reflect the reviewer. Created attachment 268142 [details]
patch to fix clang/aarch64/Linux
Addressed review comments.
Fixed the ChangeLog in http://trac.webkit.org/changeset/194517 Comment on attachment 268142 [details]
patch to fix clang/aarch64/Linux
Obsolete patch.
|