Summary: | [CMake][GTK][OSX] webkit-gtk 2.11.2: libwebkit2gtk (and others) are not installed by 'make install' | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, commit-queue, philip.chimento, pnormand | ||||||
Priority: | P3 | ||||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.11 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 126492 | ||||||||
Attachments: |
|
Description
Jeremy Huddleston Sequoia
2016-01-02 01:29:18 PST
Unfortunately, I forgot to keep the build log, so I'm re-building now and will attach the build log tomorrow. Created attachment 268176 [details]
main.log.bz2
In case it's not obvious, libwebkit2gtk-4.0.dylib is missing. Out of curiosity, why not enabling the Quartz backend? WebKitWebProcess, WebKitNetworkProcess, and LLIntOffsetsExtractor are also not installed. The Quartz backend is disabled because you cannot build with both ENABLE_X11_TARGET and ENABLE_QUARTZ_TARGET at the same time. Our users can enable ENABLE_QUARTZ_TARGET instead of ENABLE_X11_TARGET by choosing an appropriate build variant. Which version of CMake? Could it be related to https://bugs.webkit.org/show_bug.cgi?id=152183 where the GIRs are being directed to uninstalled dylibs? cmake version 3.4.1 This is likely unrelated to bug #152183. I get this on 2.11.91 with the Quartz backend as well. I think this is the culprit: http://trac.webkit.org/browser/trunk/Source/WebKit2/CMakeLists.txt#L856 Is there a different option that could be substituted for if(APPLE), or could this simply be changed to if (APPLE AND NOT PORT STREQUAL "GTK") Actually, would 'PORT STREQUAL "Mac"' be more appropriate there? Created attachment 273827 [details]
potential solution (not tested)
I forgot to followup here when I marked the patch for review and commit. I tested it, and it worked great. We're using it in MacPorts currently. Comment on attachment 273827 [details] potential solution (not tested) Clearing flags on attachment: 273827 Committed r198098: <http://trac.webkit.org/changeset/198098> All reviewed patches have been landed. Closing bug. |