| Summary: | Web Inspector: Add list-style properties to Visual Sidebar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 147563, 172574 | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2015-12-31 16:39:55 PST
Created attachment 268061 [details]
Patch
Comment on attachment 268061 [details] Patch Rejecting attachment 268061 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 268061, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: imothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Parsed 9 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 283. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/640709 Created attachment 268110 [details]
Patch
Comment on attachment 268110 [details] Patch Clearing flags on attachment: 268110 Committed r194504: <http://trac.webkit.org/changeset/194504> All reviewed patches have been landed. Closing bug. Comment on attachment 268110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268110&action=review > Source/WebInspectorUI/UserInterface/Images/ListStylePositionInside.svg:1 > +<?xml version="1.0" encoding="utf-8"?> Cool! > Source/WebInspectorUI/UserInterface/Main.html:602 > <script src="Views/VisualStyleUnitSlider.js"></script> > + <script src="Views/VisualStyleURLInput.js"></script> Actually, according to `/usr/bin/sort` these "URL" < "Unit" Comment on attachment 268110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268110&action=review >> Source/WebInspectorUI/UserInterface/Main.html:602 >> + <script src="Views/VisualStyleURLInput.js"></script> > > Actually, according to `/usr/bin/sort` these "URL" < "Unit" Oh...well I can fix that in the next Visual sidebar patch. |