Summary: | REGRESSION: scrolldelay=0 causes marquee not to display | ||
---|---|---|---|
Product: | WebKit | Reporter: | Anantha Keesara <anantha> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ddkilzer, gsherloc |
Priority: | P1 | Keywords: | HasReduction, Regression |
Version: | 523.x (Safari 3) | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://o2jam.9you.com/ | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=140863 | ||
Bug Depends on: | |||
Bug Blocks: | 17987 | ||
Attachments: |
Description
Anantha Keesara
2007-09-22 22:29:49 PDT
Created attachment 16358 [details]
scrolldelay=0 causes marquee not to display
It is displayed in release Safari on the Mac, but not in the nightly (r25699), so this is a regression. Note, in release Safari, the marquee text does overlap the left border, but at least the marquee text is there. Regressions are all P1, according to the priority guidelines. This is not a regression. It does not display in shipping Safari. Unless you are saying it is a regression from Safari 2... (In reply to comment #5) > This is not a regression. It does not display in shipping Safari. Unless you > are saying it is a regression from Safari 2... Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.11 (8S165) does not scroll the marquee, either, but it DOES show the entire text of the marquee. Safari 3.0.4 (523.12.2) with a local debug build of WebKit r29336 on 10.4.11 does not scroll the marquee, but shows the first half of the first character in the marquee on the right side of the element. So it's a regression in the sense that the text of the marquee can't be read. Maybe it should be split into two bugs then, one of which is a regression, and one of which isn't. (In reply to comment #7) > Maybe it should be split into two bugs then, one of which is a regression, and > one of which isn't. It would probably be best to simply fix the bug to make the text scroll. :) The Safari 2.0/3.0 behavior difference was just to determine if the bug was a regression or not. My guess is: if (speed() != marqueeSpeed()) { m_speed = marqueeSpeed(); if (m_timer.isActive()) m_timer.startRepeating(speed() * 0.001); } in Marquee::updateMarqueeStyle() is the buggy code. m_speed is initialized to 0 to begin with, so I believe the marquee is never started due to that check. Two things we'd need to check before making a fix are: 1. what does a negative marqueSpeed() mean? is that even possible? and 2. we may need a m_haveStartedMarqueeFirstTime bool to prevent restarting the timer when marqueeSpeed() == whatever m_speed is initialized too, and m_timer being stopped (due to an explicit stop) Created attachment 19812 [details]
Patch to make marquee elements handle empty strings in the truespeed attribute correctly
The patch appears to fix all the test cases currently attached to the bug---with the patch marquees scroll correctly on all of the test pages and without the patch none of them do.
Comment on attachment 19812 [details]
Patch to make marquee elements handle empty strings in the truespeed attribute correctly
Thanks for contributing this fix. Looks great!
This patch has tab characters in it. We can't land it like that, so please make a patch that does not have it.
+ * ChangeLog:
The ChangeLog itself should not be listed in the change log.
+ * WebCore.xcodeproj/project.pbxproj:
The project file should not be listed in the change log.
The patch needs to include a test case in the LayoutTests directory. We require a test case for each bug we fix. It should be relatively straightforward to convert the tests attached to this bug into a layout test.
review- because of the lack of tests
Created attachment 19877 [details]
Patch to make marquee elements handle empty strings in the truespeed attribute correctly, includes a new layout test, no tabs in the patch this time
Posted new patch. This one doesn't have any tab characters and includes a new layout test.
Comment on attachment 19877 [details]
Patch to make marquee elements handle empty strings in the truespeed attribute correctly, includes a new layout test, no tabs in the patch this time
Looks great! r=me
Note that this patch will need pixel test results generated as well.
Thanks Aaron!
Committed revision 31178. |