Bug 152617

Summary: More scrollOffset/scrollPosition disambiguation, in RenderLayer
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, sam, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+
Patch none

Simon Fraser (smfr)
Reported 2015-12-31 10:07:38 PST
More scrollOffset/scrollPosition disambiguation, in RenderLayer
Attachments
Patch (28.70 KB, patch)
2015-12-31 10:11 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Patch (32.51 KB, patch)
2015-12-31 10:27 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-12-31 10:11:20 PST
Created attachment 268044 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-31 10:13:52 PST
Attachment 268044 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlock.cpp:2877: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/rendering/RenderBlock.cpp:2878: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
alan
Comment 3 2015-12-31 10:17:57 PST
Comment on attachment 268044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268044&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3580 > + // FIXME: is point a ScrollOffset or ScrollPosition? Test in RTL overflow. :(
Simon Fraser (smfr)
Comment 4 2015-12-31 10:27:43 PST
Created attachment 268046 [details] Patch
WebKit Commit Bot
Comment 5 2015-12-31 10:51:11 PST
Attachment 268046 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlock.cpp:2877: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/rendering/RenderBlock.cpp:2878: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 6 2015-12-31 12:08:29 PST
https://trac.webkit.org/changeset/194466
Note You need to log in before you can comment on or make changes to this bug.