Bug 152615

Summary: [GTK][CMake] Do not override default values of build options with the default value
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-12-31 09:36:38 PST
Override the default value of build options only when the default value for the GTK+ port is actually different than the default value in WebKitFeatures.cmake. This way we don't accidentally override changes to default values in WebKitFeatures.cmake. We should use the values in WebKitFeatures.cmake except when we make an active choice to do otherwise.
Attachments
Patch (5.14 KB, patch)
2015-12-31 09:37 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-12-31 09:37:59 PST
Created attachment 268042 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-31 10:51:03 PST
Comment on attachment 268042 [details] Patch Clearing flags on attachment: 268042 Committed r194458: <http://trac.webkit.org/changeset/194458>
WebKit Commit Bot
Comment 3 2015-12-31 10:51:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.