Bug 152611

Summary: [CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch mrobinson: review+

Michael Catanzaro
Reported 2015-12-31 07:43:33 PST
If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but not to the DOM bindings generator, for example). If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are called after WEBKIT_OPTION_END, they don't do anything. Add error checking to catch these bugs.
Attachments
Patch (3.26 KB, patch)
2015-12-31 07:52 PST, Michael Catanzaro 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-12-31 07:52:05 PST
Created attachment 268034 [details] Patch
Michael Catanzaro
Comment 2 2015-12-31 09:12:27 PST
Committed r194454: <http://trac.webkit.org/changeset/194454>
Note You need to log in before you can comment on or make changes to this bug.