Bug 152606

Summary: Clarify that scrollPositionChangedViaPlatformWidget takes offsets
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, esprehn+autocc, kangil.han, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+, commit-queue: commit-queue-

Simon Fraser (smfr)
Reported 2015-12-30 21:54:28 PST
Clarify that scrollPositionChangedViaPlatformWidget takes offsets
Attachments
Patch (15.79 KB, patch)
2015-12-30 21:56 PST, Simon Fraser (smfr) 		zalan: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-12-30 21:56:55 PST
Created attachment 268028 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-31 11:03:56 PST
Comment on attachment 268028 [details] Patch Rejecting attachment 268028 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 268028, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 lines). Hunk #2 FAILED at 487. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/ScrollView.cpp.rej patching file Source/WebCore/platform/ScrollView.h patching file Source/WebCore/platform/ScrollableArea.cpp patching file Source/WebCore/platform/ScrollableArea.h patching file Source/WebKit/mac/WebView/WebHTMLView.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/631570
Simon Fraser (smfr)
Comment 3 2015-12-31 11:36:08 PST
https://trac.webkit.org/changeset/194463
Note You need to log in before you can comment on or make changes to this bug.