Bug 152596

Summary: Simplify the CachedScript ASCII optimization.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, japhet, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2015-12-30 08:17:49 PST 
The non-copying StringImpl juggling in CachedScript is scary and lame.
Comment 1 Andreas Kling 2015-12-30 08:18:26 PST 
Created attachment 268004 [details]
Patch
Comment 2 Antti Koivisto 2016-01-02 10:02:04 PST 
Comment on attachment 268004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268004&action=review

> Source/WebCore/platform/text/TextEncoding.h:75
> +        bool isByteBasedEncoding() const { return !isNonByteBasedEncoding(); }

Could we just reverse and rename isNonByteBasedEncoding?
Comment 3 Andreas Kling 2016-01-04 02:44:30 PST 
Comment on attachment 268004 [details]
Patch

We could, but I didn't want this patch to get all TextEncoding-heavy. :|
Can do separately.
Comment 4 WebKit Commit Bot 2016-01-04 03:30:35 PST 
Comment on attachment 268004 [details]
Patch

Clearing flags on attachment: 268004

Committed r194529: <http://trac.webkit.org/changeset/194529>
Comment 5 WebKit Commit Bot 2016-01-04 03:30:39 PST 
All reviewed patches have been landed.  Closing bug.