Bug 152532

Summary: [GTK] WebFrameProxy::certificateInfo() may return nullptr
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: berto, calvaris, cgarcia, clopez, commit-queue, gustavo, mcatanzaro, mrobinson, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, mcatanzaro: commit-queue-

Yusuke Suzuki
Reported 2015-12-23 11:15:55 PST
[GTK] WebFrameProxy::certificateInfo() may return nullptr
Attachments
Patch (1.69 KB, patch)
2015-12-23 11:25 PST, Yusuke Suzuki 		benjamin: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-12-23 11:25:22 PST
Created attachment 267847 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-23 11:26:51 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2015-12-23 12:48:49 PST
Comment on attachment 267847 [details] Patch Thanks for your contribution. It's a developer error to call this function when certificateInfo() is null. You're right that we should return FALSE instead of crash, but it would be better to do so with g_return_val_if_fail so that we get a runtime critical. This is already fixed appropriately in bug #142375, so I am going to dup this there. But that bug is blocked on bug #150927. It would be great if another Apple reviewer could look at the patch in bug #150927, since this is a very serious issue for us.
Michael Catanzaro
Comment 4 2015-12-23 12:49:10 PST
*** This bug has been marked as a duplicate of bug 142375 ***
Michael Catanzaro
Comment 5 2015-12-23 12:51:27 PST
P.S. In the future, please use the WebKit Gtk component for bugs like this, otherwise only some of us get CCed, and not until you upload your patch.
Note You need to log in before you can comment on or make changes to this bug.