| Summary: | [GTK] WebFrameProxy::certificateInfo() may return nullptr | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | berto, calvaris, cgarcia, clopez, commit-queue, gustavo, mcatanzaro, mrobinson, ossy | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2015-12-23 11:15:55 PST
Created attachment 267847 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 267847 [details] Patch Thanks for your contribution. It's a developer error to call this function when certificateInfo() is null. You're right that we should return FALSE instead of crash, but it would be better to do so with g_return_val_if_fail so that we get a runtime critical. This is already fixed appropriately in bug #142375, so I am going to dup this there. But that bug is blocked on bug #150927. It would be great if another Apple reviewer could look at the patch in bug #150927, since this is a very serious issue for us. *** This bug has been marked as a duplicate of bug 142375 *** P.S. In the future, please use the WebKit Gtk component for bugs like this, otherwise only some of us get CCed, and not until you upload your patch. |