Bug 152500

Summary: [GTK] media controls is always displayed when video has a text track
Product: WebKit Reporter: Wonchul Lee <wonchul.lee>
Component: MediaAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Other   
OS: Linux   
Description Flags
Patch none

Description Wonchul Lee 2015-12-22 04:35:36 PST
The media controls show up even the video does not have 'controls' attribute. 
Chrome and old (2.4.5) Webkit does not display media controls with it.

test sample : http://www.kaizou.org/demos/video-text-track-demo/
Comment 1 Wonchul Lee 2016-01-14 04:14:50 PST
Created attachment 268953 [details]
Comment 2 Michael Catanzaro 2016-01-18 06:46:05 PST
Comment on attachment 268953 [details]

Thanks for this patch. The code changes look sane, but I think this needs to be committed with a layout test, unless there's some reason it would be hard to test.
Comment 3 Wonchul Lee 2016-01-18 19:59:53 PST
Created attachment 269254 [details]
Comment 4 Wonchul Lee 2016-01-18 20:03:21 PST
@Michael, thanks for reviewing it, I updated some layout test what checked media controls not displaying on video with text track without 'controls' attribute by default and showing media controls on fullscreen regardless of 'controls' attribute.
Comment 5 Michael Catanzaro 2016-01-23 07:39:27 PST
Comment on attachment 269254 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=269254&action=review

Thanks Wonchul. Let's just rephrase the English text a bit:

> LayoutTests/media/video-controls-no-display-with-text-track-expected.txt:1
> +Tests that not showing video controls with text track without controls attribute by default and displaying it when request fullscreen

How about: "Tests that video controls are not shown for videos with a text track when the controls attribute is not present, except when fullscreen."
Comment 6 Wonchul Lee 2016-01-23 08:21:38 PST
Created attachment 269671 [details]
Comment 7 Wonchul Lee 2016-01-23 08:23:16 PST
Thanks, I rephrased it as you mentioned.
Comment 8 WebKit Commit Bot 2016-01-23 14:51:51 PST
Comment on attachment 269671 [details]

Clearing flags on attachment: 269671

Committed r195511: <http://trac.webkit.org/changeset/195511>
Comment 9 WebKit Commit Bot 2016-01-23 14:51:56 PST
All reviewed patches have been landed.  Closing bug.