Bug 152494

Summary: FTL B3 should do tail calls
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151808    
Attachments:
Description Flags
work in progress
none
the patch
msaboff: review+
pathc for landing none

Description Filip Pizlo 2015-12-21 17:30:00 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-12-21 17:31:31 PST 
Created attachment 267768 [details]
work in progress
Comment 2 Filip Pizlo 2015-12-22 11:27:41 PST 
Created attachment 267792 [details]
the patch
Comment 3 WebKit Commit Bot 2015-12-22 11:28:51 PST 
Attachment 267792 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5077:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5117:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2015-12-22 11:32:13 PST 
Comment on attachment 267792 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-12-22 11:37:30 PST 
(In reply to comment #4)
> Comment on attachment 267792 [details]
> the patch
> 
> r=me

Thanks!  I'll fix the build and land.
Comment 6 Filip Pizlo 2015-12-22 11:38:18 PST 
Created attachment 267793 [details]
pathc for landing
Comment 7 WebKit Commit Bot 2015-12-22 11:39:33 PST 
Attachment 267793 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5077:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5117:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2015-12-22 12:03:51 PST 
Landed in http://trac.webkit.org/changeset/194368