Bug 152486

Summary:

Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, lforschler, rniwa, youennf

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=159395

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-12-21 12:18:35 PST

In order to run a test in LayoutTests/imported/w3c/web-platform-tests outside of run-webkit-tests you need to follow the instructions in <http://trac.webkit.org/browser/trunk/LayoutTests/imported/w3c/web-platform-tests/README.md?rev=191043> to start the Web Platform Tests HTTP server. Although these instructions are straightforward it is less convenient to start the Web Platform Tests HTTP server than it is to run script run-webkit-httpd to start a HTTP server to serve the HTTP tests in LayoutTests/http/tests/. We should consider teaching run-webkit-httpd to start the Web Platform Tests server.

For completeness, run-webkit-tests knows how to start the Web Platform Tests HTTP server as part of its logic to run the Web Platform Tests. We should look to start up the Web Platform Tests in a similar manner as run-webkit-tests or, even better, look to have run-webkit-tests use run-webkit-httpd to start up all HTTP servers.

Comment 1 youenn fablet 2015-12-22 08:54:41 PST

Note that the wpt submodules are not checked in WebKit repository.
The README.md instructions will be successful only when these submodules are present.

Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py may be more appropriate.

It first installs (if not already done previously) these submodules (which description is found in LayoutTests/imported/w3c/resources/web-platform-tests-modules.json) on the local file system.

It then starts the wpt server using a specific configuration (stored in LayoutTests/imported/w3c/resources/config.json).

Comment 2 youenn fablet 2016-07-02 08:05:06 PDT

Created attachment 282641 [details]
Patch

Comment 3 youenn fablet 2016-07-02 08:08:26 PDT

(In reply to comment #2)
> Created attachment 282641 [details]
> Patch

This patch updates run-webkit-httpd to start or not web-platform-tests server in addition to httpd.
I guess the run-webkit-httpd should be renamed.

Comment 4 WebKit Commit Bot 2016-07-02 10:46:25 PDT

Comment on attachment 282641 [details]
Patch

Clearing flags on attachment: 282641

Committed r202780: <http://trac.webkit.org/changeset/202780>

Comment 5 WebKit Commit Bot 2016-07-02 10:46:29 PDT

All reviewed patches have been landed.  Closing bug.