Bug 152463 – [CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

[CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI

[Andy Estes]

Created attachment 267707 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 267707 [details]
Patch

Looks good, although fixing all the builds may be challenging.

[WebKit Commit Bot]

Comment on attachment 267707 [details]
Patch

Rejecting attachment 267707 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/spi/cf/CFNetworkSPI.h:134:36: note: 'CFURLCredentialStorageCreate' declared here
EXTERN_C CFURLCredentialStorageRef CFURLCredentialStorageCreate(CFAllocatorRef);
                                   ^

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/CookieJarMac.o platform/network/mac/CookieJarMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/582707

[Andy Estes]

Created attachment 267708 [details]
Patch

[Andy Estes]

Created attachment 267709 [details]
Patch

[Andy Estes]

Created attachment 267797 [details]
Patch

[Andy Estes]

Created attachment 267806 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 267806 [details]
Patch

Clearing flags on attachment: 267806

Committed r194378: <http://trac.webkit.org/changeset/194378>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #8)
> Comment on attachment 267806 [details]
> Patch
> 
> Clearing flags on attachment: 267806
> 
> Committed r194378: <http://trac.webkit.org/changeset/194378>

It broke the Apple Mac cmake build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1224

[Andy Estes]

(In reply to comment #10)
> (In reply to comment #8)
> > Comment on attachment 267806 [details]
> > Patch
> > 
> > Clearing flags on attachment: 267806
> > 
> > Committed r194378: <http://trac.webkit.org/changeset/194378>
> 
> It broke the Apple Mac cmake build:
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1224

I'm not sure how to fix this. I noticed that the WebCore.framework created by CMake is missing the Headers or PrivateHeaders directories, so I'm not sure how WebKit is supposed to find WebCore external headers.

Alex, can you help?

[Alex Christensen]

r194545 should fix that.