Bug 152450

Summary: BytecodeGenerator::pushLexicalScopeInternal and pushLexicalScope should use enums instead of bools
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, joepeck, keith_miller, mark.lam, msaboff
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
ggaren: review+
patch joepeck: review+

Saam Barati
Reported 2015-12-18 15:53:57 PST
This will make the call sites easier to read.
Attachments
patch (12.43 KB, patch)
2015-12-18 16:08 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (12.66 KB, patch)
2015-12-18 16:10 PST, Saam Barati 		ggaren: review+
DetailsFormatted DiffDiff
patch (12.74 KB, patch)
2015-12-18 16:11 PST, Saam Barati 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-12-18 16:08:15 PST
Created attachment 267656 [details] patch
Saam Barati
Comment 2 2015-12-18 16:10:19 PST
Created attachment 267657 [details] patch hopefully this builds.
Geoffrey Garen
Comment 3 2015-12-18 16:11:00 PST
r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:707 > + enum class TDZCheckOptimization { CanOptimize, CanNotOptimize }; Technically, cannot is one word. You could do Optimize / DoNotOptimize.
Saam Barati
Comment 4 2015-12-18 16:11:46 PST
Created attachment 267658 [details] patch nope, it doesn't. Maybe this time?
Saam Barati
Comment 5 2015-12-18 16:12:39 PST
(In reply to comment #3) > r=me > > > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:707 > > + enum class TDZCheckOptimization { CanOptimize, CanNotOptimize }; > > Technically, cannot is one word. > > You could do Optimize / DoNotOptimize. I'll do that.
Joseph Pecoraro
Comment 6 2015-12-18 16:16:30 PST
Comment on attachment 267658 [details] patch r=me
Saam Barati
Comment 7 2015-12-18 16:20:30 PST
landed in http://trac.webkit.org/changeset/194304
Note You need to log in before you can comment on or make changes to this bug.