Bug 152406

Summary: We should have different JSTypes for JSGlobalLexicalEnvironment and JSLexicalEnvironment and JSModuleEnvironment
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
mark.lam: review+
patch
mark.lam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-yosemite none

Saam Barati
Reported 2015-12-17 16:30:08 PST
This will give us a faster way of determining a JSLexicalEnvironment.
Attachments
patch (12.99 KB, patch)
2015-12-18 17:15 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (13.02 KB, patch)
2015-12-18 17:17 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch (21.61 KB, patch)
2016-03-15 11:59 PDT, Saam Barati 		mark.lam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-yosemite (853.41 KB, application/zip)
2016-03-15 13:08 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-12-18 17:15:55 PST
Created attachment 267663 [details] patch
Saam Barati
Comment 2 2015-12-18 17:17:26 PST
Created attachment 267664 [details] patch build fix.
Mark Lam
Comment 3 2015-12-18 17:23:44 PST
Comment on attachment 267664 [details] patch r=me if it builds and tests pass.
Saam Barati
Comment 4 2016-01-03 16:39:13 PST
Some module-related tests failed. I'll look into this tomorrow.
Saam Barati
Comment 5 2016-03-14 17:12:30 PDT
I'm going to look into this again.
Saam Barati
Comment 6 2016-03-15 11:59:55 PDT
Created attachment 274106 [details] patch up for review again because it's been a while
Mark Lam
Comment 7 2016-03-15 12:17:25 PDT
Comment on attachment 274106 [details] patch r=me
Build Bot
Comment 8 2016-03-15 13:08:29 PDT
Comment on attachment 274106 [details] patch Attachment 274106 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/984666 New failing tests: js/function-call-aliased.html
Build Bot
Comment 9 2016-03-15 13:08:32 PDT
Created attachment 274117 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Saam Barati
Comment 10 2016-03-15 13:42:23 PDT
landed in: http://trac.webkit.org/changeset/198228
Note You need to log in before you can comment on or make changes to this bug.