Bug 152406

Summary: We should have different JSTypes for JSGlobalLexicalEnvironment and JSLexicalEnvironment and JSModuleEnvironment
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
mark.lam: review+
patch
mark.lam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-yosemite none

Description Saam Barati 2015-12-17 16:30:08 PST 
This will give us a faster way of determining a JSLexicalEnvironment.
Comment 1 Saam Barati 2015-12-18 17:15:55 PST 
Created attachment 267663 [details]
patch
Comment 2 Saam Barati 2015-12-18 17:17:26 PST 
Created attachment 267664 [details]
patch

build fix.
Comment 3 Mark Lam 2015-12-18 17:23:44 PST 
Comment on attachment 267664 [details]
patch

r=me if it builds and tests pass.
Comment 4 Saam Barati 2016-01-03 16:39:13 PST 
Some module-related tests failed. I'll look into this tomorrow.
Comment 5 Saam Barati 2016-03-14 17:12:30 PDT 
I'm going to look into this again.
Comment 6 Saam Barati 2016-03-15 11:59:55 PDT 
Created attachment 274106 [details]
patch

up for review again because it's been a while
Comment 7 Mark Lam 2016-03-15 12:17:25 PDT 
Comment on attachment 274106 [details]
patch

r=me
Comment 8 Build Bot 2016-03-15 13:08:29 PDT 
Comment on attachment 274106 [details]
patch

Attachment 274106 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/984666

New failing tests:
js/function-call-aliased.html
Comment 9 Build Bot 2016-03-15 13:08:32 PDT 
Created attachment 274117 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Saam Barati 2016-03-15 13:42:23 PDT 
landed in:
http://trac.webkit.org/changeset/198228