Bug 152375

Summary: [iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bburg, beidson, cdumez, commit-queue, darin, japhet, joepeck, koivisto, mkwst
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Andy Estes
Reported 2015-12-16 19:34:07 PST
[iOS] Block loading external stylesheets in the Content-Disposition: attachment sandbox
Attachments
Patch (15.42 KB, patch)
2015-12-16 19:42 PST, Andy Estes 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2015-12-16 19:38:22 PST
rdar://problem/22020902
Andy Estes
Comment 2 2015-12-16 19:42:16 PST
Created attachment 267527 [details] Patch
Darin Adler
Comment 3 2015-12-16 21:34:00 PST
Comment on attachment 267527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267527&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:475 > + Document* document = nullptr; I don’t think we need to initialize document here. It’s initialized in all code paths below. > Source/WebCore/loader/cache/CachedResourceLoader.h:134 > + bool canRequestInContentDispositionAttachmentSandbox(CachedResource::Type, const URL&) const; I suggest making this private rather than public.
Andy Estes
Comment 4 2015-12-16 21:54:06 PST
Committed r194209: <http://trac.webkit.org/changeset/194209>
Note You need to log in before you can comment on or make changes to this bug.