| Summary: | Progress towards implementing downloads with NetworkSession | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2015-12-16 18:14:13 PST
Created attachment 267518 [details]
Patch
Comment on attachment 267518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267518&action=review > Source/WebKit2/Shared/Downloads/Download.h:65 > +#if !USE(NETWORK_SESSION) > +class ResourceHandle; > +#endif Seems unnecessary to put a conditional on a forward declaration. Also not great to have the #if in the middle like this. Normally we would put something in a separate paragraph. But I suggest just leaving this in unconditionally. (In reply to comment #2) > Comment on attachment 267518 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267518&action=review > > > Source/WebKit2/Shared/Downloads/Download.h:65 > > +#if !USE(NETWORK_SESSION) > > +class ResourceHandle; > > +#endif > > Seems unnecessary to put a conditional on a forward declaration. Also not > great to have the #if in the middle like this. Normally we would put > something in a separate paragraph. But I suggest just leaving this in > unconditionally. I am trying to make sure to never use ResourceHandle in WebKit2 when using NetworkSession, but one ResourceHandle forward declaration doesn't hurt. Committed to http://trac.webkit.org/changeset/194211 |