Bug 152371 – Progress towards implementing downloads with NetworkSession

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Progress towards implementing downloads with NetworkSession

[Alex Christensen]

Created attachment 267518 [details]
Patch

[Darin Adler]

Comment on attachment 267518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267518&action=review

> Source/WebKit2/Shared/Downloads/Download.h:65
> +#if !USE(NETWORK_SESSION)
> +class ResourceHandle;
> +#endif

Seems unnecessary to put a conditional on a forward declaration. Also not great to have the #if in the middle like this. Normally we would put something in a separate paragraph. But I suggest just leaving this in unconditionally.

[Alex Christensen]

(In reply to comment #2)
> Comment on attachment 267518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267518&action=review
> 
> > Source/WebKit2/Shared/Downloads/Download.h:65
> > +#if !USE(NETWORK_SESSION)
> > +class ResourceHandle;
> > +#endif
> 
> Seems unnecessary to put a conditional on a forward declaration. Also not
> great to have the #if in the middle like this. Normally we would put
> something in a separate paragraph. But I suggest just leaving this in
> unconditionally.

I am trying to make sure to never use ResourceHandle in WebKit2 when using NetworkSession, but one ResourceHandle forward declaration doesn't hurt.

Committed to http://trac.webkit.org/changeset/194211