Bug 152352

Summary: Web Inspector: Improve console.trace, make it more like console.assert and inline the message
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[TEST] Test Case - Inspect this page
none
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix timothy: review+

Joseph Pecoraro
Reported 2015-12-16 12:38:18 PST
* SUMMARY Improve console.trace, make it more like console.assert and inline the message. Currently console.trace("Foo", arg) completely ignores `"Foo"` and `arg`. It should behave more like console.assert, and do things with the extra parameters. * TEST (attached a standalone case) console.trace(); console.trace("Message"); console.trace("Message", 1); console.trace("Message", [1,2,3,4,5]); console.trace("Message", {a:1,b:2,c:3,d:4,e:5,f:6}); console.trace("Message", 123, "two"); * STEPS TO REPRODUCE 1. Inspect test page => Trace messages should include message and extra parameters 2. Reload test page => Trace messages should include message and extra parameters and be slightly better with previews
Attachments
[TEST] Test Case - Inspect this page (580 bytes, text/html)
2015-12-16 12:38 PST, Joseph Pecoraro
no flags
[IMAGE] Before (204.98 KB, image/png)
2015-12-16 12:38 PST, Joseph Pecoraro
no flags
[IMAGE] After (188.24 KB, image/png)
2015-12-16 12:39 PST, Joseph Pecoraro
no flags
[PATCH] Proposed Fix (7.26 KB, patch)
2015-12-16 12:45 PST, Joseph Pecoraro
timothy: review+
Joseph Pecoraro
Comment 1 2015-12-16 12:38:35 PST
Created attachment 267480 [details] [TEST] Test Case - Inspect this page
Joseph Pecoraro
Comment 2 2015-12-16 12:38:55 PST
Created attachment 267481 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2015-12-16 12:39:08 PST
Created attachment 267482 [details] [IMAGE] After
Joseph Pecoraro
Comment 4 2015-12-16 12:45:24 PST
Created attachment 267483 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 5 2015-12-16 13:00:14 PST
Patch doesn't apply because of localized strings diff.
Joseph Pecoraro
Comment 6 2015-12-17 15:45:26 PST
Note You need to log in before you can comment on or make changes to this bug.