Bug 152351

Summary: Modern IDB: Have IDBServerOperations know whether they represent an open or delete request
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1 achristensen: review+

Description Brady Eidson 2015-12-16 12:12:11 PST 
Modern IDB: Have IDBServerOperations know whether they represent an open or delete request
Comment 1 Brady Eidson 2015-12-16 12:13:54 PST 
Created attachment 267479 [details]
Patch v1
Comment 2 Alex Christensen 2015-12-16 12:24:39 PST 
Comment on attachment 267479 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=267479&action=review

> Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:58
> +    m_requestType = requestType;

m_requestType(requestType)

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:254
> +    auto operation = m_currentOperation;
> +    m_currentOperation = nullptr;

WTF::move
Comment 3 Brady Eidson 2015-12-16 12:27:18 PST 
(In reply to comment #2)
> Comment on attachment 267479 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267479&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:58
> > +    m_requestType = requestType;
> 
> m_requestType(requestType)

m_requestType belongs to the super class, so the subclass can't initialize it directly.

> 
> > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:254
> > +    auto operation = m_currentOperation;
> > +    m_currentOperation = nullptr;
> 
> WTF::move

Will-do
Comment 4 Brady Eidson 2015-12-16 12:30:06 PST 
http://trac.webkit.org/changeset/194169