Bug 152329

Summary:

Web Inspector: Improve copy of console message containing Array and Map output

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[IMAGE] Before - Used Margins	none
[IMAGE] After - Uses a Space	none

Joseph Pecoraro

Reported 2015-12-16 00:19:44 PST

* SUMMARY Improve copy of console message containing Array and Map output. * STEPS TO REPRODUCE 1. Inspect about:blank 2. js> dir([1,2,3]) 3. js> m = new Map; m.set("key", "value"); dir(m) 4. Expand both objects 5. Select both console messages and Copy => Poor formatting in copied text. * BEFORE > [Log] Array (3) > 01 > 12 > 23 > Array Prototype > > [Log] Map (1) > key"key" > value"value" > Map Prototype * AFTER > [Log] Array (3) > 0 1 > 1 2 > 2 3 > Array Prototype > > [Log] Map (1) > key "key" > value "value" > Map Prototype

Attachments
[PATCH] Proposed Fix (5.26 KB, patch) 2015-12-16 00:21 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Before - Used Margins (142.89 KB, image/png) 2015-12-16 00:21 PST, Joseph Pecoraro	no flags	Details
[IMAGE] After - Uses a Space (142.87 KB, image/png) 2015-12-16 00:22 PST, Joseph Pecoraro	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-12-16 00:19:58 PST

<rdar://problem/23916663>

Joseph Pecoraro

Comment 2 2015-12-16 00:21:30 PST

Created attachment 267444 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2015-12-16 00:21:47 PST

Created attachment 267445 [details] [IMAGE] Before - Used Margins

Joseph Pecoraro

Comment 4 2015-12-16 00:22:01 PST

Created attachment 267446 [details] [IMAGE] After - Uses a Space

WebKit Commit Bot

Comment 5 2015-12-16 09:42:38 PST

Comment on attachment 267444 [details] [PATCH] Proposed Fix Clearing flags on attachment: 267444 Committed r194150: <http://trac.webkit.org/changeset/194150>

WebKit Commit Bot

Comment 6 2015-12-16 09:42:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.