Bug 152314

Summary: REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, dbates, lforschler, mitz, mmaxfield, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 dbates: review+, dbates: commit-queue-

David Kilzer (:ddkilzer)
Reported 2015-12-15 13:58:23 PST
The change to DumpRenderTreeMain.mm in r192375 caused the iOS code path to exit immediately when calling main() as all apps are wont to do. Unfortunately, DumpRenderTreeMain.mm was used for both DumpRenderTree command-line binary and DumpRenderTree.app, which meant that the app would exit immediately with no error code when run! The workaround is to introduce a separate source file called DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner already does.
Attachments
Patch v1 (11.89 KB, patch)
2015-12-15 14:00 PST, David Kilzer (:ddkilzer) 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2015-12-15 14:00:46 PST
Created attachment 267392 [details] Patch v1
Daniel Bates
Comment 2 2015-12-15 14:06:18 PST
Comment on attachment 267392 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=267392&action=review > Tools/ChangeLog:10 > + The change to DumpRenderTreeMain.mm in r192375 caused the iOS > + code path to exit immediately when calling main() as all apps > + are wont to do. Unfortunately, DumpRenderTreeMain.mm was used The first sentence does not read well. In particular, the phrase "as all apps are wont to do" does not read well.
David Kilzer (:ddkilzer)
Comment 3 2015-12-15 14:11:11 PST
Committed r194115: <http://trac.webkit.org/changeset/194115>
David Kilzer (:ddkilzer)
Comment 4 2015-12-15 14:34:50 PST
<rdar://problem/23546265>
Note You need to log in before you can comment on or make changes to this bug.