Bug 152288

Summary: FTL B3 should account for localsOffset
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151808    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2015-12-14 19:09:16 PST
Patch forthcoming.
Attachments
the patch (18.50 KB, patch)
2015-12-14 19:18 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-14 19:18:48 PST
Created attachment 267335 [details] the patch
Saam Barati
Comment 2 2015-12-14 19:27:57 PST
Comment on attachment 267335 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267335&action=review r=me > Source/JavaScriptCore/ChangeLog:30 > + ValueFromBlock fooValue = things; This should be "LValue fooValue = things;"
Filip Pizlo
Comment 3 2015-12-14 19:29:17 PST
(In reply to comment #2) > Comment on attachment 267335 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267335&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:30 > > + ValueFromBlock fooValue = things; > > This should be "LValue fooValue = things;" Yup, fixed.
Filip Pizlo
Comment 4 2015-12-14 20:54:17 PST
Landed in http://trac.webkit.org/changeset/194092
Note You need to log in before you can comment on or make changes to this bug.