Bug 152288

Summary: FTL B3 should account for localsOffset
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 151808    
Attachments:
Description Flags
the patch saam: review+

Description Filip Pizlo 2015-12-14 19:09:16 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2015-12-14 19:18:48 PST
Created attachment 267335 [details]
the patch
Comment 2 Saam Barati 2015-12-14 19:27:57 PST
Comment on attachment 267335 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267335&action=review

r=me

> Source/JavaScriptCore/ChangeLog:30
> +            ValueFromBlock fooValue = things;

This should be "LValue fooValue = things;"
Comment 3 Filip Pizlo 2015-12-14 19:29:17 PST
(In reply to comment #2)
> Comment on attachment 267335 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267335&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:30
> > +            ValueFromBlock fooValue = things;
> 
> This should be "LValue fooValue = things;"

Yup, fixed.
Comment 4 Filip Pizlo 2015-12-14 20:54:17 PST
Landed in http://trac.webkit.org/changeset/194092