| Summary: | Web Inspector: Stack traces in console incorrectly show "(anonymous function)" for global code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 267324 [details]
[PATCH] Proposed Fix
Created attachment 267325 [details]
[IMAGE] Before
Created attachment 267327 [details]
[IMAGE] After
Comment on attachment 267324 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267324&action=review r=me I will note for posterity that I don't like the name "program" for a top-level evaluation. I prefer (evaluation), (module evaluation), (global evaluation), etc. If we had a fake call frame for the vm entry method (rAF, parsing, events, etc) then we could use that as the "program" call frame in the UI. > Source/WebInspectorUI/UserInterface/Models/CallFrame.js:135 > + var functionName = payload.functionName; Nit: let Comment on attachment 267324 [details] [PATCH] Proposed Fix Clearing flags on attachment: 267324 Committed r194083: <http://trac.webkit.org/changeset/194083> All reviewed patches have been landed. Closing bug. |
* SUMMARY Stack traces in console incorrectly show "(anonymous function)" for global code. * TEST <script> function foo() { bar(); } function bar() { console.trace(); } foo(); </script> * STEPS TO REPRODUCE 1. Open test case 2. Show Console in inspector => trace output lists "(anonymous function)" at global code level. This is wrong / incorrect.