Summary: | Web Inspector: Convert Sidebar classes to use View | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 152269 | ||||||||
Attachments: |
|
Description
Matt Baker
2015-12-14 14:30:23 PST
Created attachment 267349 [details]
[Patch] Proposed Fix
Comment on attachment 267349 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=267349&action=review r=me A little surprised we don't need to call needsLayout anywhere. I suppose the panels just add and remove sections, so the sections should become dirty, not the panel. > Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js:61 > var shownSection = this._probeSetSections.get(probeSet); Nit: let > Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js:-49 > - { Comment for ChangeLog: "defer to View.element getter." It says no longer needed, but the getter is still used (just implemented elsewhere). Created attachment 267391 [details]
[Patch] Proposed Fix
Comment on attachment 267391 [details] [Patch] Proposed Fix Clearing flags on attachment: 267391 Committed r194116: <http://trac.webkit.org/changeset/194116> All reviewed patches have been landed. Closing bug. |